Migrate @storybook/channel-postmessage to TypeScript #5154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandean
commented
Jan 6, 2019
Codecov Report
@@ Coverage Diff @@
## next #5154 +/- ##
==========================================
- Coverage 35.25% 35.23% -0.02%
==========================================
Files 596 596
Lines 7397 7401 +4
Branches 1010 1015 +5
==========================================
Hits 2608 2608
- Misses 4276 4285 +9
+ Partials 513 508 -5
Continue to review full report at Codecov.
|
ndelangen
approved these changes
Jan 7, 2019
kroeder
reviewed
Jan 7, 2019
| if (!iframeWindow) { | ||
| return new Promise((resolve, reject) => { | ||
| this._buffer.push({ event, resolve, reject }); | ||
| this.buffer.push({ event, resolve, reject }); | ||
| }); | ||
| } | ||
| const data = stringify({ key: KEY, event }); | ||
| iframeWindow.postMessage(data, '*'); | ||
| return Promise.resolve(null); |
There was a problem hiding this comment.
return Promise.resolve(null) feels odd
In all return cases, the return value should be void right? This existed before your PR, I just thought this should be fixed because this return value is part of the public API now
@ndelangen what do you think?
Like this:
send(event: ChannelEvent): Promise<void> {
const iframeWindow = this.getWindow();
if (!iframeWindow) {
return new Promise((resolve, reject) => {
this._buffer.push({ event, resolve, reject });
this.buffer.push({ event, resolve, reject });
});
}
const data = stringify({ key: KEY, event });
iframeWindow.postMessage(data, '*');
return Promise.resolve();
}There was a problem hiding this comment.
I'm cool with whatever you and @ndelangen decide. Happy to make the patch if you want me to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5030
What I did
Migrate
@storybook/channel-postmessageto TypeScriptHow to test
There are no existing tests for this module.